feat: Allow setting terminationGracePeriodSeconds#826
Merged
robholland merged 1 commit intotemporalio:mainfrom Feb 4, 2026
Merged
feat: Allow setting terminationGracePeriodSeconds#826robholland merged 1 commit intotemporalio:mainfrom
robholland merged 1 commit intotemporalio:mainfrom
Conversation
robholland
requested changes
Jan 22, 2026
robholland
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Allow setting terminationGracePeriodSeconds for server deployment.
Default value is set to null instead of 0.
It doesn't allow setting terminationGracePeriodSeconds to 0 but that shouldn't be too much limitation.Why?
This can be used to give higher drain time when shutting down services during a deployment
Checklist
Closes
How was this tested: Added unit test